Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2048 python gui clone #272

Merged
merged 3 commits into from
Nov 6, 2023
Merged

2048 python gui clone #272

merged 3 commits into from
Nov 6, 2023

Conversation

choidf
Copy link
Contributor

@choidf choidf commented Nov 5, 2023

Pull Request Template

Feature Name:
2048 gui clone using pygame
Changes made:

Issue num (must) - #127

Self Check(Tick After Making pull Request)

  • I have read and followed the Contribution Guidelines

  • This issue was assigned to me.

  • One Change in one Pull Request

  • My file is in the proper folder

  • PR is regarding Code

  • I am following clean code and Documentation and my code is well linted with flake8.

  • I am using external libraries and I have created requirements.txt in my project folder

  • Script is tested and running perfectly fine on my system

  • PR is regarding the documentation

If the issue was not assigned to you Please don't make a PR, It will be marked as invalid.

Discuss in discord server:- http://pragmaticprogrammer.in/discord

acknowledgment

  • I have tested my code and distributing it under GPL-3.0 License

@Punit-Choudhary Punit-Choudhary self-requested a review November 5, 2023 12:01
@Punit-Choudhary Punit-Choudhary added Project Projects category linting-required Code is not properly linted. Use CodeBeautify to format. labels Nov 5, 2023
@Punit-Choudhary
Copy link
Owner

Hey @choidf, please lint your code properly. Here is the flake8 output:

./Projects/2048/2048.py:48:1: E302 expected 2 blank lines, found 1
./Projects/2048/2048.py:79:80: E501 line too long (85 > 79 characters)
./Projects/2048/2048.py:82:80: E501 line too long (81 > 79 characters)
./Projects/2048/2048.py:84:80: E501 line too long (82 > 79 characters)
./Projects/2048/2048.py:96:80: E501 line too long (80 > 79 characters)
./Projects/2048/2048.py:106:5: E266 too many leading '#' for block comment

Please let me know if you need any sort of help regarding this.

@choidf
Copy link
Contributor Author

choidf commented Nov 5, 2023

Hey @choidf, please lint your code properly. Here is the flake8 output:

./Projects/2048/2048.py:48:1: E302 expected 2 blank lines, found 1
./Projects/2048/2048.py:79:80: E501 line too long (85 > 79 characters)
./Projects/2048/2048.py:82:80: E501 line too long (81 > 79 characters)
./Projects/2048/2048.py:84:80: E501 line too long (82 > 79 characters)
./Projects/2048/2048.py:96:80: E501 line too long (80 > 79 characters)
./Projects/2048/2048.py:106:5: E266 too many leading '#' for block comment

Please let me know if you need any sort of help regarding this.

My bad. I've linted the script. Could you check it again?

@Punit-Choudhary Punit-Choudhary merged commit 0fb3879 into Punit-Choudhary:main Nov 6, 2023
1 check passed
@Punit-Choudhary
Copy link
Owner

Hey @choidf, Thank you so much for your contribution 🎉 💜

@Punit-Choudhary Punit-Choudhary added hacktoberfest-accepted and removed linting-required Code is not properly linted. Use CodeBeautify to format. labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants