(#195) Update .nvmrc file with correct Node Version #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seyilonge-ps
force-pushed
the
ticket/195-update-files-with-correct-node-version
branch
3 times, most recently
from
145943b to
7b853da
Compare
3 tasks
zoltan-dulac
previously approved these changes
Aug 26, 2024
|
@seyilonge-ps Is there any more work needed to be done here? |
@zoltan-dulac Yes, the test script to check node versions specified in |
seyilonge-ps
force-pushed
the
ticket/195-update-files-with-correct-node-version
branch
from
7b853da to
1759ae7
Compare
seyilonge-ps
force-pushed
the
ticket/195-update-files-with-correct-node-version
branch
2 times, most recently
from
4c06dfc to
71a3e02
Compare
Closes #195 * Updated `.nvmrc` and `README.md` files with correct Node version * Added `engines` property to `package.json` to specify Node and npm version ranges * Added `.npmrc` file and set `engine-strict` property to `true` * Updated Node version for GitHub actions * Updated `README.md` file `Setup` section * Added validation script file * Removed `console.log` from test files * Added `chromedriver_force_download=true` to `.npmrc` file * Updated `chromedriver` from version `126.0.4` to `128.0.1` * Removed `git add` task from `lint-staged` run script * Updated chrome browser version for download in github `push-actions.yml` file
seyilonge-ps
force-pushed
the
ticket/195-update-files-with-correct-node-version
branch
from
71a3e02 to
63d10e2
Compare
zoltan-dulac
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.nvmrcandREADME.mdfiles with correct Node versionenginesproperty topackage.jsonto specify Node and npm version ranges.npmrcfile and setengine-strictproperty totrue