(#153) Enforce using rems/ems in stylesheets #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoltan-dulac
requested changes
Aug 15, 2024
seyilonge-ps
force-pushed
the
ticket/153-enforce-rem-em-use
branch
from
d12c058 to
ea9cb3a
Compare
seyilonge-ps
force-pushed
the
ticket/153-enforce-rem-em-use
branch
from
ea9cb3a to
9170f89
Compare
seyilonge-ps
force-pushed
the
ticket/153-enforce-rem-em-use
branch
from
9170f89 to
61e753f
Compare
zoltan-dulac
reviewed
Sep 9, 2024
less/accessible-text-svg.less
Outdated
| @@ -10,27 +10,27 @@ body { | |||
|
|
|||
| &__text { | |||
| fill: black; | |||
| stroke-width: 2px; | |||
| font-size: calc(54px * var(--text-zoom-factor)); | |||
| stroke-width: 0.125rem; | |||
There was a problem hiding this comment.
I was hoping we can just force font-size to be in rems. Is there a way of doing that?
less/chart.less
Outdated
| border: solid 1px black; | ||
| width: initial; | ||
| } | ||
|
|
||
| svg { | ||
| font-size: 16px; | ||
| font-size: 1rem; |
There was a problem hiding this comment.
I think there is a little misunderstanding. I would like font-size to use the LESS mixin (i.e. 16/@px).
This is to be consistent with the advice we are giving on this page:
https://www.useragentman.com/enable/text-resize.php#replace-pixels-with-rems--heading
Your check can look at the resultant CSS to make sure there are no px units in a font-size property, if that makes it easier.
Let's talk more about this tomorrow.
seyilonge-ps
force-pushed
the
ticket/153-enforce-rem-em-use
branch
from
61e753f to
a54f653
Compare
Closes #153 * Added and enabled `stylelint-rem-over-px` * Fixed console errors * Removed `stylelint-rem-over-px` for `stylelint`'s `declaration-property-unit-allowed-list` rule which allows for greater flexibility * Cleaned up console errors * Separated `stylelint` into it's own task for `lint-staged` * Fxied up font-size calculations
seyilonge-ps
force-pushed
the
ticket/153-enforce-rem-em-use
branch
from
a54f653 to
31d89e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153
stylelint-rem-over-px