BUILD 2017.02.28-001 #356
Merged
BUILD 2017.02.28-001 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Issue #348 - Video embed now treats video embed as a 1:1 pointer to provider video oEmbed data. URL field is no longer editable after being saved, since changing the URL would be the same as removing the video and adding a new one. - Added drag-and-drop support for video URL's into Video embed modal via plain text (dragged from address bar) or link HTML (dragged from link to video URL). - Added support for promises to be returned by embedType's getModelFromForm method.
Issue #349 - Added oEmbed data - Prepopulate title with oEmbed data if no title has previously been entered - Unified spelling of event handler params in most embed types
- All private methods should now be function statements instead of vars.
Issue #348 - Using Vimeo oEmbed API to support option their extened options and prevent mangling of mulitbyte characters.
Updated Video embed modal to support oEmbed data
Issue #349 - Added oEmbed data from Twitter API to Twitter embed model - Twitter embed modal now constructs a titel with oEmbed data if a title has not already been entered - Twitter embed URL's are no longer editable after being added. - Added `embedCode` key to clean model of Facebook embed.
# Conflicts: # src/js/demo.js # src/js/templateCache.js
Issue #349 - Instagram embed models now include oEmbed data - Instagram embed modals now construct titles from oEmbed data, if one has not already been entered. - Updated toolbar positioning logic to allow each embed type to define a selector to get a locator container. - Added `src/js/templateCache.js` to .gitignore
- Changed .overlay to .video-embed-inner for Video embed template and styles.
- Embeds should be re-rendered when positioning style has changed. - Toolbars positioning now polls for changes to embed container size for 2 seconds after a style change and adjust position when a difference is encountered.
- Facebook, Twitter, and Instagram embed now generate a title from oEmbed data, simlilar to: 'Author Name - January 15, 2016 - First ten words of post...'. This format contains all information that could be needed to search for a post and provides a solid starting point for users when coming up with a title. Titles are still editable and a generated title will not be used if a title was previously entered.
Issue #349 - Updated embed rendering to add object_type as a class to embed container element for embed type layout styling. - Added min-widths to Facebook, Twitter, and Instagram embed container styling. - Social post embeds should no longer run title generation when title is already provided. - Updated embed container positioning styles to not float embed on screens smaller than a tablet.
Issue #351 - Updated embed HTML generated for editor to contain elements for fields that have values. - Added drag-and-drop support to External Link embed modal for image field, similar to Image embed. - Updated embed types that support file uploads to use file URL returned from API and not assume and force an assumed domain.
Added oEmbed data to social embeds
- Issue #351 - Updated CSS styles for External Links embed to work with new embed template markup. - Fixed issue with parent.initModal
- Updated Newsletter Subscribe embed to generate embed markup for optional fields that have values - Rearranged Newsletter Subscribe modal fields to group fields by relavence - Updated Newsletter Subscribe embed CSS to be more consistent across position styles. - Reverted model key names in External links embed data
- Updated embed HTML to not include credit element when not provided - Made Quote URL Text field to make sure a text is available when generating link HTML for the required Quote URL.
No more 'null' items in embed HTML
- GlobalBuzz quote image should be styled by platform-admin CSS to prevent images from having to be packaged by embed-containers.
Issue #354 - Removed hard-coded template URL's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #348, #349, #351, #354