OTT-1807: discard emptyVAST and invalidVAST bids detected by VAST unwrap module #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ashishshinde-pubm
commented
Aug 10, 2024
•
ashishshinde-pubm
commented
- Removes the bids with empty-VAST and invalid-VAST from participating in the auction.
- Add such rejected bids in seatNonBids
- Removes VastUnwrapStatsEnabled feature flag
pm-nikhil-vaidya
requested changes
Aug 22, 2024
pm-nikhil-vaidya
previously approved these changes
Aug 27, 2024
pm-viral-vala
previously approved these changes
Aug 30, 2024
pm-viral-vala
dismissed stale reviews from pm-jaydeep-mohite and themself
The base branch was changed.
AvinashKapre
pushed a commit
that referenced
this pull request
Sep 21, 2024
…rap module (#874) * OTT-1807: discard emptyVAST and invalidVAST bids
pm-viral-vala
pushed a commit
that referenced
this pull request
Sep 26, 2024
…rap module (#874) * OTT-1807: discard emptyVAST and invalidVAST bids
pm-viral-vala
pushed a commit
that referenced
this pull request
Sep 26, 2024
…rap module (#874) * OTT-1807: discard emptyVAST and invalidVAST bids
pm-viral-vala
pushed a commit
that referenced
this pull request
Oct 7, 2024
…rap module (#874) * OTT-1807: discard emptyVAST and invalidVAST bids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.