Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit armor headers in sorted order #255

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

andrewgdotcom
Copy link
Contributor

closes #254

Copy link
Contributor

@lubux lubux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@twiss
Copy link
Member

twiss commented Dec 3, 2024

For completeness, in case this is something you care about, note that key serialization for entities with multiple user IDs is also not deterministic:

for _, ident := range e.Identities {
(and the same applies in SerializePrivate).

@andrewgdotcom
Copy link
Contributor Author

key serialization for entities with multiple user IDs is also not deterministic:

We don't call that code in hockeypuck AFAICT. We have a standard sort order that gets applied to packet sequences before display in the index view, which we can also apply to armored output.

@twiss twiss merged commit b01f065 into ProtonMail:main Dec 3, 2024
8 checks passed
@andrewgdotcom andrewgdotcom deleted the issue-254 branch December 3, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit armor headers in sorted order
3 participants