Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit armor headers in sorted order #254

Closed
andrewgdotcom opened this issue Dec 2, 2024 · 0 comments · Fixed by #255
Closed

Emit armor headers in sorted order #254

andrewgdotcom opened this issue Dec 2, 2024 · 0 comments · Fixed by #255

Comments

@andrewgdotcom
Copy link
Contributor

In hockeypuck/hockeypuck#220 I have several users complaining about armored output with randomly-sorted headers breaking workflows that try to detect changes. While it is not recommended to use a bitwise comparison of armored output for this, some environments have tooling restrictions that make it difficult to include an OpenPGP parser into the workflow.

It is relatively simple (and harmless!) to sort the armor headers in the encoder, and it would eliminate the vast majority of such false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant