Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seaport 1.4 #999

Draft
wants to merge 18 commits into
base: seaport-1.3
Choose a base branch
from
Draft

Seaport 1.4 #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f57874d
Bump cacheable-request from 10.2.3 to 10.2.7
dependabot[bot] Feb 11, 2023
9656f87
fix amount tracking bug in reference order combiner
Feb 15, 2023
10b2b76
Merge pull request #994 from ProjectOpenSea/dan/2023/02/fix-amount-tr…
0age Feb 15, 2023
92a1b38
Bump undici from 5.13.0 to 5.19.1
dependabot[bot] Feb 16, 2023
1c22012
Merge pull request #996 from ProjectOpenSea/seaport-1.3
0age Feb 17, 2023
9409a6c
Merge pull request #995 from ProjectOpenSea/dependabot/npm_and_yarn/u…
0age Feb 17, 2023
e089ad8
Merge pull request #972 from ProjectOpenSea/dependabot/npm_and_yarn/c…
0age Feb 17, 2023
c84e61b
only call validateOrder / ratifyOrder on available orders
0age Feb 17, 2023
c9057ac
bump version to 1.4
0age Feb 17, 2023
708a7b3
add 1.4 gas report
0age Feb 17, 2023
604644c
update package.json
0age Feb 17, 2023
84b4a68
always revert when contract orders return bad data
0age Feb 18, 2023
bb5d395
fix hardhat tests
0age Feb 18, 2023
667b6db
update gas report
0age Feb 18, 2023
5686494
bring reference contracts in line with optimized
0age Feb 18, 2023
4795218
update bad offerer tests
jameswenzel Feb 18, 2023
1aa86e4
Merge pull request #998 from ProjectOpenSea/1.4
0age Feb 18, 2023
92765ef
update with 1.4 deployment address
0age Feb 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 62 additions & 62 deletions ...2c1285e31df6b46c36aaf72dbcff2d6e58a3.json → ...39539354e96cf6e69ad107906a0b6a46ea91.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
{
"commitHash": "ddea2c1285e31df6b46c36aaf72dbcff2d6e58a3",
"commitHash": "bb5d39539354e96cf6e69ad107906a0b6a46ea91",
"contractReports": {
"Conduit": {
"name": "Conduit",
"methods": [
{
"method": "execute",
"min": 77459,
"max": 2168532,
"avg": 449559,
"min": 77435,
"max": 2179914,
"avg": 451436,
"calls": 6
},
{
"method": "executeBatch1155",
"min": null,
"max": null,
"avg": 97245,
"avg": 97221,
"calls": 1
},
{
"method": "executeWithBatch1155",
"min": 97717,
"max": 361430,
"avg": 228767,
"min": 97669,
"max": 361418,
"avg": 228749,
"calls": 4
},
{
Expand Down Expand Up @@ -64,14 +64,14 @@
"method": "transferOwnership",
"min": null,
"max": null,
"avg": 50329,
"avg": 50317,
"calls": 2
},
{
"method": "updateChannel",
"min": 34454,
"max": 121098,
"avg": 117294,
"avg": 117293,
"calls": 71
}
],
Expand All @@ -85,7 +85,7 @@
"method": "createConduit",
"min": 226092,
"max": 231533,
"avg": 229596,
"avg": 229598,
"calls": 6
}
],
Expand All @@ -106,7 +106,7 @@
"method": "registerDigest",
"min": 22239,
"max": 44151,
"avg": 36847,
"avg": 36843,
"calls": 3
},
{
Expand Down Expand Up @@ -148,7 +148,7 @@
"method": "cancelOrders",
"min": null,
"max": null,
"avg": 65339,
"avg": 65327,
"calls": 1
}
],
Expand Down Expand Up @@ -183,7 +183,7 @@
"method": "cancelOrders",
"min": null,
"max": null,
"avg": 73894,
"avg": 73870,
"calls": 1
},
{
Expand All @@ -204,14 +204,14 @@
"method": "executeMatchAdvancedOrders",
"min": null,
"max": null,
"avg": 288785,
"avg": 289151,
"calls": 2
},
{
"method": "executeMatchOrders",
"min": null,
"max": null,
"avg": 282325,
"avg": 282751,
"calls": 2
},
{
Expand All @@ -238,8 +238,8 @@
{
"method": "prepare",
"min": 49267,
"max": 2351654,
"avg": 1061779,
"max": 2351690,
"avg": 1061771,
"calls": 26
}
],
Expand All @@ -251,51 +251,51 @@
"methods": [
{
"method": "cancel",
"min": 41250,
"max": 58422,
"avg": 54039,
"min": 41226,
"max": 58374,
"avg": 54030,
"calls": 16
},
{
"method": "fulfillAdvancedOrder",
"min": 96288,
"max": 225181,
"avg": 159382,
"avg": 159350,
"calls": 194
},
{
"method": "fulfillAvailableAdvancedOrders",
"min": 149626,
"max": 350749,
"avg": 214389,
"calls": 33
"max": 260680,
"avg": 203090,
"calls": 30
},
{
"method": "fulfillAvailableOrders",
"min": 164998,
"max": 215740,
"avg": 201364,
"min": 164986,
"max": 215752,
"avg": 201359,
"calls": 21
},
{
"method": "fulfillBasicOrder",
"min": 90639,
"max": 1621627,
"avg": 598707,
"avg": 598705,
"calls": 187
},
{
"method": "fulfillBasicOrder_efficient_6GL6yc",
"min": 90261,
"max": 111456,
"avg": 100859,
"max": 111468,
"avg": 100865,
"calls": 6
},
{
"method": "fulfillOrder",
"min": 119409,
"max": 225080,
"avg": 176772,
"avg": 176770,
"calls": 108
},
{
Expand All @@ -308,36 +308,36 @@
{
"method": "matchAdvancedOrders",
"min": 179574,
"max": 300213,
"avg": 248903,
"max": 300473,
"avg": 248933,
"calls": 77
},
{
"method": "matchOrders",
"min": 157474,
"max": 348243,
"avg": 264537,
"min": 157522,
"max": 348207,
"avg": 264552,
"calls": 151
},
{
"method": "validate",
"min": 53177,
"min": 53201,
"max": 83910,
"avg": 73542,
"avg": 73546,
"calls": 29
}
],
"bytecodeSize": 26099,
"deployedBytecodeSize": 24374
"bytecodeSize": 26114,
"deployedBytecodeSize": 24389
},
"SeaportRouter": {
"name": "SeaportRouter",
"methods": [
{
"method": "fulfillAvailableAdvancedOrders",
"min": 183942,
"min": 183954,
"max": 311883,
"avg": 233578,
"avg": 233586,
"calls": 6
}
],
Expand All @@ -351,8 +351,8 @@
"method": "activate",
"min": 201519,
"max": 246674,
"avg": 205512,
"calls": 33
"avg": 205288,
"calls": 35
},
{
"method": "activateWithCriteria",
Expand Down Expand Up @@ -399,16 +399,16 @@
{
"method": "mint",
"min": 47235,
"max": 49903,
"avg": 49427,
"calls": 239
"max": 49879,
"avg": 49421,
"calls": 236
},
{
"method": "setApprovalForAll",
"min": 26102,
"max": 46002,
"avg": 45645,
"calls": 446
"avg": 45380,
"calls": 448
}
],
"bytecodeSize": 4173,
Expand All @@ -421,8 +421,8 @@
"method": "approve",
"min": 28881,
"max": 46245,
"avg": 45807,
"calls": 390
"avg": 45780,
"calls": 338
},
{
"method": "blockTransfer",
Expand All @@ -433,10 +433,10 @@
},
{
"method": "mint",
"min": 33994,
"min": 33982,
"max": 68458,
"avg": 67563,
"calls": 190
"avg": 67466,
"calls": 164
},
{
"method": "setNoReturnData",
Expand All @@ -455,16 +455,16 @@
{
"method": "mint",
"min": 51492,
"max": 68784,
"avg": 65745,
"calls": 282
"max": 68796,
"avg": 66042,
"calls": 315
},
{
"method": "setApprovalForAll",
"min": 26195,
"max": 46095,
"avg": 45506,
"calls": 474
"avg": 45578,
"calls": 540
}
],
"bytecodeSize": 5238,
Expand Down Expand Up @@ -504,8 +504,8 @@
{
"method": "bulkTransfer",
"min": 77935,
"max": 1428982,
"avg": 633808,
"max": 1492854,
"avg": 664509,
"calls": 3
}
],
Expand Down
Loading