Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only copy signature calldata region to memory when it is needed for BasicOrders #55

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Only copy signature calldata region to memory when it is needed for BasicOrders #55

merged 1 commit into from
Mar 5, 2024

Conversation

Saw-mon-and-Natalie
Copy link
Collaborator

0age
0age suggested changes Mar 5, 2024
View reviewed changes
src/core/lib/OrderValidator.sol
// Read the relative pointer to the order signature.
CalldataPointer
.wrap(BasicOrder_signature_cdPtr)
.readMaskedUint256() +
Copy link
Contributor

@0age 0age Mar 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be unchecked as it's reading a masked pointer (applies prior to this PR too)

@0age 0age merged commit c912945 into main Mar 5, 2024
4 checks passed
@0age 0age deleted the basic-order-optimize-validate-sig branch March 5, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0age 0age 0age approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saw-mon-and-Natalie @0age