-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image annotation insert/edit to mirador-annotations #50
Open
MImranAsghar
wants to merge
7
commits into
ProjectMirador:master
Choose a base branch
from
utlib:Add-img-annotation-insert-edit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add image annotation insert/edit to mirador-annotations #50
MImranAsghar
wants to merge
7
commits into
ProjectMirador:master
from
utlib:Add-img-annotation-insert-edit
Commits on May 9, 2021
-
Create image annotation creation dialog
- This dialog is needed to extend the annotation support to adding image annotation. - Expects user to enter url; calculates width and height of image - Includes image dialog input validation; checks url, width, height
Configuration menu - View commit details
-
Copy full SHA for ac164d8 - Browse repository at this point
Copy the full SHA ac164d8View commit details -
Add 'constrain image proportions' functionality ...
... in the image annotation input/edit - If the constrain proportions checkbox is checked in image annotation input, this functionality will make sure that the image proportions are maintained if either a new width or height is entered - These image annotation insert/edit changes attempt to implement image insert/edit workflow similar to Mirador 2
Configuration menu - View commit details
-
Copy full SHA for a160f11 - Browse repository at this point
Copy the full SHA a160f11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 664e834 - Browse repository at this point
Copy the full SHA 664e834View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3afafb3 - Browse repository at this point
Copy the full SHA 3afafb3View commit details
Commits on May 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f8f957b - Browse repository at this point
Copy the full SHA f8f957bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fedaefb - Browse repository at this point
Copy the full SHA fedaefbView commit details
Commits on May 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1cf3ea4 - Browse repository at this point
Copy the full SHA 1cf3ea4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.