-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support financial ACLs #731
base: master
Are you sure you want to change the base?
Conversation
ab6ba39 replaces manual SQL queries with API4 calls (with The commit also adds a TODO for retrieving how many of the last installments have failed, which is being done with some regex in another SQL query, but does not expose unpermissioned contribution information - the query should be replaced eventually, but does no harm for now. |
2b32610
to
615c4ab
Compare
…ns (effectively respecting financialacls)
615c4ab
to
2f87cc7
Compare
The API4 The Create Mandate form uses this action for retrieving mandates to clone/replace. Also, the form only allows permissioned financial types to be selected. The API3 action |
29ab676
to
3ab15c2
Compare
3ab15c2
to
d67ce17
Compare
The The CiviSEPA dashboard uses the |
… to view all contributions
…tering for permissioned financial types only
Refactored the contribution list view per CiviSEPA transaction group to use API4, effectively blocking access to groups with contributions of financial types the user does not have permissions for. |
There is a new (global) setting for whether to create transaction groups by financial types instead of by creditor/collection date/mandate type only. Updating OOFF groups is implemented, implementation for RCUR groups is pending. Cleanup of contributions still works the same (ensuring each contribution is in only one transaction group). |
6609362
to
63f1ed4
Compare
63f1ed4
to
4ca9b65
Compare
Report queries seem to be already covered by Financial ACLs. |
…PIv4 calls for checking Financial ACLs permissions
897857a
to
1ac233f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently I cannot judge the questions in the TODOs. Probably I've commented some translations that weren't changed, but just moved to a different position.
} | ||
$this->assign('contact_id', $contactId); | ||
$this->assign( | ||
'financialacls', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd name it financialacls_installed
or financialacls_available
.
I've left out issues with translation and naming for now, but they should still be taken care of … |
I think at least renaming |
…than the result count
…than the result count
…geate function `GROUP_FIRST` not available earlier
systopia-reference: 25698