Create yaml file for ELUC use case CI #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofrancon
approved these changes
Mar 21, 2024
.github/workflows/eluc.yml
Outdated
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | ||
| - name: Run unit tests | ||
| run: python -m unittest | ||
| - name: Lint with PyLint |
There was a problem hiding this comment.
You should run pylint before the unit tests. First check the code is 'clean' (fast), then run the tests (slow).
|
|
||
| on: | ||
| push: | ||
| branches: [ "main" ] |
There was a problem hiding this comment.
Can we run it on all branch? Because we shouldn't be able to merge if pylint or the tests fail
There was a problem hiding this comment.
Currently runs whenever a PR goes into main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First try at CI.