-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++14. Let's do this. #1975
C++14. Let's do this. #1975
Conversation
Also, I haven't yet looked into this error:
https://ci.appveyor.com/project/DennisOSRM/osrm-backend/build/1.0.2564#L1705 Has anything related to |
Yes 3075f6c |
Disabled the OSX shared lib build. In addition to not finding libosrm, it had a single cucumber test failing: https://travis-ci.org/Project-OSRM/osrm-backend/jobs/108934582#L481 I could not reproduce it locally via
and all the other builds are fine, too. |
Travis gives okay! Disclaimer: requires C++14 compiler and stdlib. That is, gcc<=4.8 is out. Also clang<=3.4 is out since it would require Let's require gcc>=4.9, clang>=3.5 and re-write the docs to simply install the gcc 5.3 ppa for older Ubuntus. gcc 4.9 is in Debian Jessie, so we're fine there. |
I got diff --git a/src/engine/engine.cpp b/src/engine/engine.cpp
index c9fe44e..2949de1 100644
--- a/src/engine/engine.cpp
+++ b/src/engine/engine.cpp
@@ -22,6 +22,7 @@
#include <boost/assert.hpp>
#include <boost/interprocess/sync/named_condition.hpp>
#include <boost/interprocess/sync/scoped_lock.hpp>
+#include <boost/thread/lock_types.hpp>
#include <algorithm>
#include <fstream>
Also had to patch boost as it disables some c++11 and c++14 features for Visual Studio by default: e.g.:
Uploaded an updated binary deps package. Tests are failing as it seems that |
Lock types fix landed in #1994 |
Urg looks like the auto merging f-ed up in this case after rebasing. We run against gcc 5.0 and gcc 4.9 now, right? |
Yes, packages are gcc-5 (which really is gcc 5.3) and gcc-4.9. |
Rebased onto develop. |
Please reopen the PR for |
Reference: mapbox/windows-builds#78
@BergWerkGIS there's no flag for Visual Studio, is there? The default will be good enough?
Let's see how both Appveyor and Travis like this.