-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Chat Search #16
base: master
Are you sure you want to change the base?
Feat: Chat Search #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And other comments from Twitch stream
useState<IMessage[]>(messages); | ||
const messagesToRender = searchTerm.trim() ? filteredMessages : messages; | ||
|
||
// This function is called whenever the search term changes in the SearchDialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function name itself implies what this does, so no need for the comment.
const handleSearchChange = (newSearchTerm: string) => { | ||
setSearchTerm(newSearchTerm); | ||
|
||
// Fuse.js options; adjust as needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary comment.
Summary:
Description:
! I don't know if we should update the results when a new message is received that matches the search... This is something we could implement if it is needed.