perf(proposals): update project proposal approval buttons to use ofetch

PrivateAIM · Sep 9, 2024 · f46f9cc · f46f9cc
1 parent 5aedb47
commit f46f9cc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 30 deletions.
diff --git a/components/projects/ApproveRejectButtons.vue b/components/projects/ApproveRejectButtons.vue
@@ -1,5 +1,4 @@
 <script setup lang="ts">
-import { approveRejectProjectProposal } from "~/composables/useAPIFetch";
 import { useToastService } from "~/composables/connectionErrorToast";
 
 const props = defineProps({
@@ -13,14 +12,20 @@ const emit = defineEmits(["updatedRow"]);
 
 async function onSubmitProjectApproval(isApproved: boolean) {
   loading.value = true;
-  const { data: response, status } = await approveRejectProjectProposal(
-    isApproved,
-    props.projectId!,
-  );
-  if (status.value === "success") {
+
+  const formData = new FormData();
+  formData.append("approval_status", isApproved ? "approved" : "rejected");
+  const approvalResp = await useNuxtApp()
+    .$hubApi(`/project-nodes/${props.projectId}`, {
+      method: "POST",
+      body: formData,
+    })
+    .catch(() => null);
+
+  if (approvalResp) {
     showSuccessfulSubmission(isApproved);
     // Send data to parent component
-    emit("updatedRow", response.value);
+    emit("updatedRow", approvalResp);
   } else {
     showFailedSubmission();
   }

diff --git a/composables/useAPIFetch.ts b/composables/useAPIFetch.ts
@@ -27,19 +27,6 @@ export function useAPIFetch<T>(
 }
 
 // Hub endpoints
-export function approveRejectProjectProposal(
-  approved: boolean,
-  project_id: string,
-) {
-  const formData = new FormData();
-  formData.append("approval_status", approved ? "approved" : "rejected");
-
-  return useAPIFetch(`/project-nodes/${project_id}`, {
-    method: "POST",
-    body: formData,
-  });
-}
-
 export function getProposals(opts?) {
   return useAPIFetch<{ data: ListProjectNodes }>("/project-nodes", {
     ...opts,
@@ -84,16 +71,6 @@ export function getAnalysisNodes(opts?) {
   );
 }
 
-export function updateAnalysis(analysis_id: string, updates) {
-  // const formData = new FormData();
-  // formData.append("approval_status", approved ? "approved" : "rejected");
-
-  return useAPIFetch(`/analyses/${analysis_id}`, {
-    method: "POST",
-    body: updates,
-  });
-}
-
 // Kong endpoints
 export function getDataStores(includeProject: boolean, opts?) {
   // return nuxtApp.$hubApi("/kong/datastore", {