-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing divergence error with AMR (Issue #617) #625
Open
tomidakn
wants to merge
9
commits into
master
Choose a base branch
from
amrfix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f67588f
First implementation
tomidakn 339840b
Use unordered_map, support periodic BC
tomidakn ab7d5fe
Style and comment fix
tomidakn 578e0d0
locmap was not cleared correctly
tomidakn 5413eec
Minor update for performance
tomidakn 19c0c29
style fix
tomidakn 4a27016
Update src/mesh/amr_loadbalance.cpp
felker b7e8f99
Apply suggestions from code review
felker fed4b64
Update amr_loadbalance.cpp
tomidakn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you say a bit about why this moved from being a (mostly?) "multigrid-specific" feature?
I see that the
LogicalLocationHash
andunordered_map
's are currently used in Multigrid andmeshblock_tree.*
Can you say more about the maps / can the same maps be shared across these classes?