-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Improve "update:check-requirements" command #1025
Open
M0rgan01
wants to merge
1
commit into
PrestaShop:dev
Choose a base branch
from
M0rgan01:improve-check-requirements-command
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CLI] Improve "update:check-requirements" command #1025
M0rgan01
wants to merge
1
commit into
PrestaShop:dev
from
M0rgan01:improve-check-requirements-command
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting for #1016 |
M0rgan01
force-pushed
the
improve-check-requirements-command
branch
3 times, most recently
from
November 20, 2024 14:49
7b93bb2
to
c044299
Compare
M0rgan01
force-pushed
the
improve-check-requirements-command
branch
from
November 25, 2024 11:04
c044299
to
6703cdb
Compare
M0rgan01
force-pushed
the
improve-check-requirements-command
branch
from
November 26, 2024 14:05
6703cdb
to
48706eb
Compare
ga-devfront
previously approved these changes
Nov 27, 2024
@@ -58,6 +59,8 @@ protected function configure(): void | |||
->setDescription('Check all prerequisites for an update.') | |||
->setHelp('This command allows you to check the prerequisites necessary for the proper functioning of an update.') | |||
->addOption('config-file-path', null, InputOption::VALUE_REQUIRED, 'Configuration file location for update.') | |||
->addOption('zip', null, InputOption::VALUE_REQUIRED, 'Sets the archive zip file for a local update.') | |||
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.') | |
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.') |
M0rgan01
force-pushed
the
improve-check-requirements-command
branch
from
November 27, 2024 12:37
48706eb
to
7505134
Compare
Quality Gate passedIssues Measures |
Quetzacoalt91
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update:check-requirements
with new options