Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): cursor display error for resize border line button #41 #46

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(core): cursor display error for resize border line button #41 #46

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f763e6
Fixes #41
XiaoDaiGua-Ray Sep 15, 2023
774a2ec
Update core/src/components/Resizable.scss
XiaoDaiGua-Ray Sep 15, 2023
89fcd05
Update core/src/components/Resizable.scss
XiaoDaiGua-Ray Sep 15, 2023
093a873
Update core/src/components/Resizable.scss
XiaoDaiGua-Ray Sep 15, 2023
ccdbcc5
Update core/src/components/Resizable.scss
NWYLZW Sep 15, 2023
a8c7ead
Update core/src/components/Resizable.scss
NWYLZW Sep 15, 2023
f902656
Update core/src/components/Resizable.scss
NWYLZW Sep 15, 2023
8d5f752
Apply suggestions from code review
NWYLZW Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions core/src/components/Resizable.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
z-index: 100;
position: absolute;
background-color: #cacdd1;
transition: .1s;
html[theme-mode=dark] & {
transition: 0.1s;
XiaoDaiGua-Ray marked this conversation as resolved.
Show resolved Hide resolved
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
html[theme-mode="dark"] & {
XiaoDaiGua-Ray marked this conversation as resolved.
Show resolved Hide resolved
background-color: #494c50;
&:hover {
background-color: #fff5;
Expand All @@ -40,7 +40,7 @@
transform: translate(-50%, -50%);

opacity: 0;
transition: .1s;
transition: 0.1s;
XiaoDaiGua-Ray marked this conversation as resolved.
Show resolved Hide resolved
> button {
display: flex;
align-items: center;
Expand All @@ -55,13 +55,15 @@
background-color: color-mix(in srgb, var(--primary), var(--bg-cr) 50%);
border: 1px solid color-mix(in srgb, var(--primary), var(--bg-cr) 80%);

cursor: pointer;
transition: .1s;
cursor: e-resize;
transition: 0.1s;
XiaoDaiGua-Ray marked this conversation as resolved.
Show resolved Hide resolved
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
&:hover {
box-shadow: 0 0 2px gray;
background-color: color-mix(in srgb, var(--primary), var(--bg-cr) 30%);
}
> span.cldr { font-size: 12px }
> span.cldr {
font-size: 12px;
}
XiaoDaiGua-Ray marked this conversation as resolved.
Show resolved Hide resolved
}
}
&:hover &__btns {
Expand All @@ -71,14 +73,16 @@
z-index: 10;
background-color: #0008;
}
&__top > &__btns, &__bottom > &__btns {
&__top > &__btns,
&__bottom > &__btns {
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
flex-direction: row;
> button {
width: 30px;
height: 16px;
}
}
&__left, &__right {
&__left,
&__right {
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
top: 0;
width: var(--inner-border-width);
height: 100%;
Expand All @@ -87,7 +91,8 @@
width: calc(var(--inner-border-width) * var(--inner-border-scale));
}
}
&__top, &__bottom {
&__top,
&__bottom {
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
left: 0;
width: 100%;
height: var(--inner-border-width);
Expand Down
37 changes: 17 additions & 20 deletions src/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
display: flex;
align-items: center;
justify-content: space-between;
padding: .6em;
padding: 0.6em;
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
background: var(--primary);
box-shadow: 0 0 16px #00000047;
color: #fff;
overflow: hidden;
transition: .1s;
transition: 0.1s;
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
a {
display: flex;
align-items: center;
Expand All @@ -31,12 +31,12 @@
display: flex;
align-items: center;
gap: 10px;
.svg-icon {
.svg-icon {
display: flex;
align-items: center;
cursor: pointer;
filter: drop-shadow(0 0 0 #0000);
transition: .3s;
transition: 0.3s;
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
&:hover {
filter: drop-shadow(0 0 4px #000);
}
Expand All @@ -60,8 +60,13 @@
}
&.left {
flex-direction: row-reverse;
cursor: e-resize;
XiaoDaiGua-Ray marked this conversation as resolved.
Show resolved Hide resolved
}
&:not(.eval-logs-visible) {
.ppd-resizable-border__right .ppd-resizable-border__btns button {
cursor: w-resize;
}

.ppd-resizable-border__left .cldr.codicon.codicon-debug-continue-small {
transform: rotate(0deg) !important;
}
Expand Down Expand Up @@ -89,20 +94,12 @@
height: 100%;

background-size: 150% 150%;
background-image: linear-gradient(120deg,
#a1c4fd,
#c2e9fb,
#fefdfc
);
html[theme-mode=dark] & {
background-image: linear-gradient(120deg,
#8999D1,
#6E8DCA,
#4264BC
);
background-image: linear-gradient(120deg, #a1c4fd, #c2e9fb, #fefdfc);
html[theme-mode="dark"] & {
background-image: linear-gradient(120deg, #8999d1, #6e8dca, #4264bc);
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
}

transition: .2s;
transition: 0.2s;
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
> main {
position: absolute;
top: 50%;
Expand All @@ -112,8 +109,8 @@
min-width: 300px;
padding: 10px;
filter: drop-shadow(0 5px 8px #00000037);
transition: .2s;
html[theme-mode=dark] & {
transition: 0.2s;
html[theme-mode="dark"] & {
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
filter: drop-shadow(0 10px 20px #00000078);
}
}
Expand All @@ -133,7 +130,7 @@
background-color: var(--bg-cr-o0);
backdrop-filter: blur(12px);
box-shadow: 0 5px 16px #00000020;
transition: .3s;
transition: 0.3s;
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
> .menu-item {
display: flex;
align-items: center;
Expand All @@ -149,7 +146,7 @@
font-size: 18px;

cursor: pointer;
transition: .3s;
transition: 0.3s;
NWYLZW marked this conversation as resolved.
Show resolved Hide resolved
&:hover {
background-color: var(--primary-hover);
}
Expand Down