Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant class attributes #1639

Merged

Conversation

lsmedia
Copy link
Contributor

@lsmedia lsmedia commented Aug 10, 2024

⚡ PowerGrid - Pull Request

Motivation

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change
  • Minor improvement

Description

The class attributes of the two icons search and filter are redundant, as they were explicitly specified on the one hand and are injected by the component attributes on the other.

Related Issue(s): none

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

@luanfreitasdev luanfreitasdev merged commit 26e6449 into Power-Components:5.x Aug 13, 2024
17 of 18 checks passed
@lsmedia lsmedia deleted the minor-icons-improvement branch August 14, 2024 20:07
@lsmedia lsmedia restored the minor-icons-improvement branch August 19, 2024 18:05
@lsmedia lsmedia deleted the minor-icons-improvement branch August 19, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants