Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the persisting can now be used with session variables instead of cookies #1509

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

marineusde
Copy link
Contributor

…okies

⚡ PowerGrid - Pull Request

Welcome and thank you for your interest in contributing to our project!. You must use this template to submit a Pull Request or it will not be accepted.


Motivation

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change

Description

the developer can configure, that the persisting works with session storage instead of cookies

Related Issue(s): #1508 .

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

Copy link
Collaborator

@luanfreitasdev luanfreitasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

Can you add some tests?

resources/config/livewire-powergrid.php Outdated Show resolved Hide resolved
@luanfreitasdev luanfreitasdev added the request changes Request Changes label Apr 18, 2024
@luanfreitasdev luanfreitasdev marked this pull request as draft April 18, 2024 16:03
@marineusde marineusde marked this pull request as ready for review April 21, 2024 07:51
@luanfreitasdev luanfreitasdev removed the request changes Request Changes label Apr 26, 2024
@marineusde
Copy link
Contributor Author

Do you have any other suggestions for the pull request? :)

@luanfreitasdev luanfreitasdev self-requested a review April 29, 2024 09:50
@luanfreitasdev luanfreitasdev merged commit 6c80df0 into Power-Components:5.x Apr 29, 2024
42 checks passed
@luanfreitasdev
Copy link
Collaborator

Thank you @marineusde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants