1372 datepicker cant reset the datepicker filter undefined array key …

…start (#1375) * Fix "Undefined array key start * Rollback pipelines - mysql and pgsql * Remove FilterDateTimeTest - "As we deal with javascript, I need to test using cypress later"
Power-Components · Feb 2, 2024 · 7fd887c · 7fd887c
1 parent 4ffab6f
commit 7fd887c
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 202 deletions.
diff --git a/.github/workflows/mysql.yml b/.github/workflows/mysql.yml
@@ -1,7 +1,17 @@
 name: MySQL
 
 on:
-  workflow_dispatch:
+  push:
+    branches:
+      - "**"
+    paths-ignore:
+      - "art/**"
+      - "README.md"
+  pull_request:
+    types: [ready_for_review, synchronize, opened]
+    paths-ignore:
+      - "art/**"
+      - "README.md"
 
 jobs:
   build:

diff --git a/.github/workflows/pgsql.yml b/.github/workflows/pgsql.yml
@@ -1,7 +1,17 @@
 name: PostGreSQL
 
 on:
-  workflow_dispatch:
+  push:
+    branches:
+      - "**"
+    paths-ignore:
+      - "art/**"
+      - "README.md"
+  pull_request:
+    types: [ready_for_review, synchronize, opened]
+    paths-ignore:
+      - "art/**"
+      - "README.md"
 
 jobs:
   build:

diff --git a/src/Components/Filters/Builders/DatePicker.php b/src/Components/Filters/Builders/DatePicker.php
@@ -14,6 +14,10 @@ public function builder(EloquentBuilder|QueryBuilder $builder, string $field, in
             return;
         }
 
+        if (!isset($values['start']) || isset($values['end'])) {
+            return;
+        }
+
         /** @var array $values */
         [$startDate, $endDate] = [
             0 => Carbon::parse($values['start'])->format('Y-m-d'),
@@ -34,6 +38,10 @@ public function builder(EloquentBuilder|QueryBuilder $builder, string $field, in
 
     public function collection(Collection $collection, string $field, int|array|string|null $values): Collection
     {
+        if (!isset($values['start']) || isset($values['end'])) {
+            return $collection;
+        }
+
         /** @var array $values */
         [$startDate, $endDate] = [
             0 => Carbon::parse($values[0])->format('Y-m-d'),

diff --git a/src/Components/Filters/Builders/DateTimePicker.php b/src/Components/Filters/Builders/DateTimePicker.php
@@ -14,6 +14,10 @@ public function builder(EloquentBuilder|QueryBuilder $builder, string $field, in
             return;
         }
 
+        if (!isset($values['start']) || isset($values['end'])) {
+            return;
+        }
+
         /** @var array $values */
         [$startDate, $endDate] = [
             0 => Carbon::parse($values['start']),
@@ -34,6 +38,10 @@ public function builder(EloquentBuilder|QueryBuilder $builder, string $field, in
 
     public function collection(Collection $collection, string $field, int|array|string|null $values): Collection
     {
+        if (!isset($values['start']) || isset($values['end'])) {
+            return $collection;
+        }
+
         /** @var array $values */
         [$startDate, $endDate] = [
             0 => Carbon::parse($values['start']),

diff --git a/tests/Feature/Filters/FilterDateTimeTest.php b/tests/Feature/Filters/FilterDateTimeTest.php