fix(filters): fix number filter (#1153)

* fix(filters): fix number filter unable to execute sql with incorrect cast text user input to number field * fix phpstan --------- Co-authored-by: luanfreitasdev <[email protected]>
Power-Components · Sep 15, 2023 · 30c38f3 · 30c38f3
1 parent 79da200
commit 30c38f3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/Traits/HasFilter.php b/src/Traits/HasFilter.php
@@ -296,6 +296,8 @@ public function filterNumberStart(array $params, string $value): void
 
         $this->resetPage();
 
+        $value = filter_var($value, FILTER_SANITIZE_NUMBER_INT);
+
         $this->filters['number'][$field]['start']     = $value;
         $this->filters['number'][$field]['thousands'] = $thousands;
         $this->filters['number'][$field]['decimal']   = $decimal;
@@ -318,6 +320,8 @@ public function filterNumberEnd(array $params, string $value): void
 
         $this->resetPage();
 
+        $value = filter_var($value, FILTER_SANITIZE_NUMBER_INT);
+
         $this->filters['number'][$field]['end']       = $value;
         $this->filters['number'][$field]['thousands'] = $thousands;
         $this->filters['number'][$field]['decimal']   = $decimal;
@@ -329,7 +333,7 @@ public function filterNumberEnd(array $params, string $value): void
             $this->clearFilter($field, emit: false);
         }
 
-        $this->afterChangedNumberEndFilter($field, $value, $title);
+        $this->afterChangedNumberEndFilter($field, $title, $value);
 
         $this->persistState('filters');
     }

diff --git a/src/Traits/Listeners.php b/src/Traits/Listeners.php
@@ -47,11 +47,11 @@ public function afterChangedBooleanFilter(string $field, string $label, string $
     {
     }
 
-    public function afterChangedNumberStartFilter(string $field, string $label, string $value): void
+    public function afterChangedNumberStartFilter(string $field, string $label, string|false $value): void
     {
     }
 
-    public function afterChangedNumberEndFilter(string $field, string $label, string $value): void
+    public function afterChangedNumberEndFilter(string $field, string $label, string|false $value): void
     {
     }
 }