feat: Add cookieless server hash mode #25915
Draft
+309
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
commented
Oct 31, 2024
| event.properties['$device_id'] = hashValue | ||
|
|
||
| // TRICKY: if a user were to log in and out, to avoid collisions, we would want a different hash value, so we store the set of identify event uuids for identifies | ||
| // ASSUMPTION: all events are processed in order, and are processed exactly once |
There was a problem hiding this comment.
this assumption doesn't hold, events are at least once, so we need to be able to deal with the same identify event happening twice
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Co-authored-by: Rafael Audibert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
WIP
Changes
WIP
Allow posthog-js to pass a sentinel value for distinct id, session id, and device id, which will get converted to actual values server-side based on a hash of some properties that are included with the request (e.g. user agent, ip address, etc)
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
TODO