chore: convert 2 more test files to remove given and switch to TS #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 719 kB ℹ️ View Unchanged
|
pauldambra
changed the title
pauldambra
commented
Nov 9, 2023
Comment on lines
+104
to
+113
| // if the hash state does not contain ph_authorize then look in storage | ||
| localStorage.getItem.mockImplementation(() => JSON.stringify(toolbarParams)) | ||
|
|
||
| const hashState = { ...defaultHashState, action: undefined } | ||
| toolbar.maybeLoadToolbar(aLocation(withHash(withHashParamsFrom(hashState))), localStorage, history) | ||
|
|
||
| expect(toolbar.loadToolbar).toHaveBeenCalledWith({ | ||
| ...toolbarParams, | ||
| source: 'localstorage', | ||
| }) |
There was a problem hiding this comment.
this test changed as well as being converted. it wasn't actually testing what it claimed it was, it's still maybe too confusing
pauldambra
commented
Nov 9, 2023
Comment on lines
+129
to
+136
| it('should work if calling toolbar params `__posthog`', () => { | ||
| toolbar.maybeLoadToolbar( | ||
| aLocation(withHash(withHashParamsFrom(defaultHashState, '__posthog'))), | ||
| localStorage, | ||
| history | ||
| ) | ||
| expect(toolbar.loadToolbar).toHaveBeenCalledWith({ ...toolbarParams, ...defaultHashState, source: 'url' }) | ||
| }) |
There was a problem hiding this comment.
this test changed as well as being converted, it wasn't actually testing what it said it was
daibhin
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin