Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make the default recorder-js v2 #813

Closed
wants to merge 2 commits into from
Closed

Conversation

benjackwhite
Copy link
Collaborator

Changes

Part 1 of removing the old rrweb. Both files will now be v2 (we need to keep both for compatibility with old code pointing to the "v2" file but now the contents are the same.

Follow up PR will be to change the SDK to only load recorder.js once we validate that it has been distributed to the CDN.

Checklist

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Size Change: +70.9 kB (+10%) ⚠️

Total Size: 783 kB

Filename Size Change
dist/array.full.js 212 kB +34.3 kB (+19%) ⚠️
dist/recorder.js 95 kB +36.6 kB (+63%) 🆘
ℹ️ View Unchanged
Filename Size
dist/array.js 119 kB
dist/es.js 119 kB
dist/module.js 119 kB
dist/recorder-v2.js 95 kB
dist/surveys.js 23.6 kB

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does we need to worry about the bump in size?

@benjackwhite
Copy link
Collaborator Author

Does we need to worry about the bump in size?

Note really - rrweb2 is just bigger.

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Collaborator

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants