chore: playwright tests #1631
Merged
chore: playwright tests #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +560 B (+0.02%) Total Size: 3.22 MB
ℹ️ View Unchanged
|
pauldambra
commented
Dec 28, 2024
| @@ -1323,6 +1323,7 @@ export class SessionRecording { | |||
| * */ | |||
| public overrideLinkedFlag() { | |||
| this._linkedFlagSeen = true | |||
| this._tryTakeFullSnapshot() | |||
There was a problem hiding this comment.
genuine bug for this luckily pretty rarely called method
pauldambra
commented
Dec 28, 2024
| @@ -1337,6 +1338,7 @@ export class SessionRecording { | |||
| // short-circuits the `makeSamplingDecision` function in the session recording module | |||
| [SESSION_RECORDING_IS_SAMPLED]: true, | |||
| }) | |||
| this._tryTakeFullSnapshot() | |||
There was a problem hiding this comment.
genuine bug for this luckily pretty rarely called method
This reverts commit 40def25.
ioannisj
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress tests don't run in browserstack because they were so slow in browserstack/multiple browsers
Which means session replay tests (and most e2e tests) are only exercised in the electron browser. But we can have e.g. safari specific bugs and would never catch them.
Since we know Cypress was annoyingly slow here let's not use it.
This PR ports all session recording tests from Cypress to Playwright
Why Playwright?