Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add feature name prop to event #1624

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Dec 19, 2024

Changes

Adds the $name prop to an early access enrolment event cc @joethreepwood

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@daibhin daibhin added the bump minor Bump minor version when this PR gets merged label Dec 19, 2024
@daibhin daibhin requested a review from benjackwhite December 19, 2024 16:12
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 20, 2024 10:16am

Copy link

github-actions bot commented Dec 19, 2024

Size Change: +1.11 kB (+0.03%)

Total Size: 3.22 MB

Filename Size Change
dist/array.full.es5.js 262 kB +126 B (+0.05%)
dist/array.full.js 365 kB +109 B (+0.03%)
dist/array.full.no-external.js 364 kB +109 B (+0.03%)
dist/array.js 179 kB +109 B (+0.06%)
dist/array.no-external.js 178 kB +109 B (+0.06%)
dist/main.js 180 kB +109 B (+0.06%)
dist/module.full.js 365 kB +109 B (+0.03%)
dist/module.full.no-external.js 364 kB +109 B (+0.03%)
dist/module.js 179 kB +109 B (+0.06%)
dist/module.no-external.js 178 kB +109 B (+0.06%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is name perhaps a little to generic? On the other hand maybe having it as a generic property could be a good thing if we start using it more 🤔

@daibhin
Copy link
Contributor Author

daibhin commented Dec 20, 2024

Is name perhaps a little to generic? On the other hand maybe having it as a generic property could be a good thing if we start using it more 🤔

No I think you're right. I'd convinced myself $name was ok given it was scoped to the event but forgot that you are often searching for event properties. Doesn't make sense to be so generic in that case. Updated to $early_access_feature_name

@daibhin daibhin merged commit ba53bac into main Dec 20, 2024
28 checks passed
@daibhin daibhin deleted the dn-chore/add-feature-name-prop branch December 20, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants