Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove circular dependencies #1618

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

pauldambra
Copy link
Member

rollup warns about circular dependencies when building...
it doesn't seem to be a problem but we may as well remove a little noise since reorganising is free

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 18, 2024 8:47am

Copy link

Size Change: -427 B (-0.01%)

Total Size: 3.22 MB

Filename Size Change
dist/all-external-dependencies.js 206 kB +8 B (0%)
dist/array.full.es5.js 262 kB +12 B (0%)
dist/array.full.js 365 kB +8 B (0%)
dist/array.full.no-external.js 364 kB +8 B (0%)
dist/array.js 179 kB -161 B (-0.09%)
dist/array.no-external.js 178 kB -4 B (0%)
dist/customizations.full.js 12.6 kB -4 B (-0.03%)
dist/main.js 180 kB -161 B (-0.09%)
dist/module.full.js 365 kB +8 B (0%)
dist/module.full.no-external.js 364 kB +8 B (0%)
dist/module.js 179 kB -155 B (-0.09%)
dist/module.no-external.js 178 kB +8 B (0%)
dist/recorder-v2.js 115 kB +4 B (0%)
dist/recorder.js 115 kB +4 B (0%)
dist/surveys.js 63.3 kB -10 B (-0.02%)
ℹ️ View Unchanged
Filename Size
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/surveys-preview.js 57.6 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra pauldambra requested a review from a team December 18, 2024 09:15
Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the tiniest bundle size reductions :shipit:

@pauldambra pauldambra merged commit c2acbc9 into main Dec 18, 2024
14 checks passed
@pauldambra pauldambra deleted the chore/pd/circular-dependencies branch December 18, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants