Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Small tweaks after making fetch the default request implementation #1610

Merged

Conversation

rafaeelaudibert
Copy link
Member

@rafaeelaudibert rafaeelaudibert commented Dec 16, 2024

Changes

Lets reorder our request implementation to use fetch as the default in case someone specifies an unknown method, rather than using XHR

Closes #1487

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 18, 2024 6:19pm

@rafaeelaudibert rafaeelaudibert added the bump minor Bump minor version when this PR gets merged label Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

Size Change: 0 B

Total Size: 3.22 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/array.full.es5.js 262 kB
dist/array.full.js 365 kB
dist/array.full.no-external.js 364 kB
dist/array.js 179 kB
dist/array.no-external.js 178 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/main.js 180 kB
dist/module.full.js 365 kB
dist/module.full.no-external.js 364 kB
dist/module.js 179 kB
dist/module.no-external.js 178 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@rafaeelaudibert rafaeelaudibert force-pushed the move-over-to-fetch-as-default-over-xmlhttprequest branch from af98f16 to 499cd7d Compare December 16, 2024 18:13
@rafaeelaudibert rafaeelaudibert force-pushed the move-over-to-fetch-as-default-over-xmlhttprequest branch from 499cd7d to 7b7645f Compare December 16, 2024 19:29
@rafaeelaudibert rafaeelaudibert force-pushed the move-over-to-fetch-as-default-over-xmlhttprequest branch from 7b7645f to 8b6362a Compare December 16, 2024 19:41
@rafaeelaudibert rafaeelaudibert force-pushed the move-over-to-fetch-as-default-over-xmlhttprequest branch from 8b6362a to fcc761a Compare December 16, 2024 19:58
@rafaeelaudibert rafaeelaudibert force-pushed the move-over-to-fetch-as-default-over-xmlhttprequest branch from fcc761a to ae92c71 Compare December 16, 2024 20:37
@rafaeelaudibert rafaeelaudibert force-pushed the move-over-to-fetch-as-default-over-xmlhttprequest branch from ae92c71 to 9fff069 Compare December 16, 2024 20:47
@rafaeelaudibert rafaeelaudibert force-pushed the move-over-to-fetch-as-default-over-xmlhttprequest branch from 9fff069 to cd8a1c2 Compare December 16, 2024 21:03
@rafaeelaudibert rafaeelaudibert force-pushed the move-over-to-fetch-as-default-over-xmlhttprequest branch from cd8a1c2 to bcb9093 Compare December 18, 2024 18:12
Lets reorder our request implementation to use fetch as the default in case someone specifies an unknown method, rather than using XHR
@rafaeelaudibert rafaeelaudibert force-pushed the move-over-to-fetch-as-default-over-xmlhttprequest branch from bcb9093 to 3546a8b Compare December 18, 2024 18:14
@rafaeelaudibert rafaeelaudibert changed the title chore: Make fetch our default request implementation chore: Small tweaks after making fetch the default request implementation Dec 18, 2024
@rafaeelaudibert rafaeelaudibert marked this pull request as ready for review December 18, 2024 18:17
@rafaeelaudibert rafaeelaudibert added bump patch Bump patch version when this PR gets merged and removed bump minor Bump minor version when this PR gets merged labels Dec 18, 2024
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafaeelaudibert rafaeelaudibert merged commit 1638dfc into main Dec 18, 2024
18 checks passed
@rafaeelaudibert rafaeelaudibert deleted the move-over-to-fetch-as-default-over-xmlhttprequest branch December 18, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Load failed when page is unloaded before posthog events are finished sending
2 participants