Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make legacy property sturdier #1602

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

rafaeelaudibert
Copy link
Member

This property might be accessed/called before we've properly initialized feature flags, so let's make sure we're not breaking anything (we have broken it already, see https://posthog.slack.com/archives/C02E3BKC78F/p1734111258352399)

Checklist

  • Tests for new code (see advice on the tests we use)
    • No tests for now, but we should add it eventually, we need to guarantee this doesn't break anymore
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

This property might be accessed/called before we've properly initialized feature flags, so let's make sure we're not breaking anything (we have broken it already, see https://posthog.slack.com/archives/C02E3BKC78F/p1734111258352399)
@rafaeelaudibert rafaeelaudibert added the bump patch Bump patch version when this PR gets merged label Dec 13, 2024
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 13, 2024 5:47pm

Copy link

Size Change: +660 B (+0.02%)

Total Size: 3.21 MB

Filename Size Change
dist/array.full.es5.js 260 kB +66 B (+0.03%)
dist/array.full.js 363 kB +66 B (+0.02%)
dist/array.full.no-external.js 362 kB +66 B (+0.02%)
dist/array.js 178 kB +66 B (+0.04%)
dist/array.no-external.js 176 kB +66 B (+0.04%)
dist/main.js 178 kB +66 B (+0.04%)
dist/module.full.js 363 kB +66 B (+0.02%)
dist/module.full.no-external.js 362 kB +66 B (+0.02%)
dist/module.js 178 kB +66 B (+0.04%)
dist/module.no-external.js 176 kB +66 B (+0.04%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@rafaeelaudibert rafaeelaudibert merged commit 4c99b6a into main Dec 13, 2024
17 checks passed
@rafaeelaudibert rafaeelaudibert deleted the fix-feature-flags-access branch December 13, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants