Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: angular change detection clashing #1530

Closed
wants to merge 4 commits into from

Conversation

pauldambra
Copy link
Member

we get periodic reports of performance issues with angular

angular change detection patches browser methods

we do change detection too

so we fight each other

this grabs methods from an iframe so that we aren't using angular's patched methods

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ❌ Failed (Inspect) Nov 18, 2024 10:55am

@pauldambra
Copy link
Member Author

this is way easier to test thanks to a customer providing a repo here https://github.com/typedb/angular-posthog-freeze

Copy link

github-actions bot commented Nov 18, 2024

Size Change: +19.2 kB (+0.62%)

Total Size: 3.13 MB

Filename Size Change
dist/all-external-dependencies.js 205 kB +1 kB (+0.49%)
dist/array.full.es5.js 254 kB +635 B (+0.25%)
dist/array.full.js 356 kB +891 B (+0.25%)
dist/array.full.no-external.js 355 kB +891 B (+0.25%)
dist/array.js 171 kB +746 B (+0.44%)
dist/array.no-external.js 171 kB +748 B (+0.44%)
dist/dead-clicks-autocapture.js 14 kB +1.04 kB (+7.99%) 🔍
dist/exception-autocapture.js 9.61 kB +810 B (+9.2%) 🔍
dist/external-scripts-loader.js 3.05 kB +852 B (+38.82%) 🚨
dist/main.js 172 kB +737 B (+0.43%)
dist/module.full.js 356 kB +891 B (+0.25%)
dist/module.full.no-external.js 355 kB +891 B (+0.25%)
dist/module.js 171 kB +746 B (+0.44%)
dist/module.no-external.js 171 kB +747 B (+0.44%)
dist/recorder-v2.js 114 kB +830 B (+0.73%)
dist/recorder.js 114 kB +830 B (+0.73%)
dist/surveys-preview.js 58.4 kB +1.72 kB (+3.03%)
dist/surveys.js 63 kB +856 B (+1.38%)
dist/tracing-headers.js 2.98 kB +1.65 kB (+123.85%) 🆘
dist/web-vitals.js 12 kB +1.69 kB (+16.35%) ⚠️

compressed-size-action

@pauldambra
Copy link
Member Author

can make a smaller change

@pauldambra pauldambra closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant