Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove custom exceptions endpoint #1513

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 5, 2024

Changes

We use the regular endpoint for now so no need to handle the custom case

https://github.com/PostHog/posthog/blob/9b9118943ee7d5e9697d8cc0e0dcf24b8f3f89ea/posthog/api/decide.py#L243-L249

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 6, 2024 11:09am

Copy link

github-actions bot commented Nov 5, 2024

Size Change: -5.24 kB (-0.17%)

Total Size: 3 MB

Filename Size Change
dist/array.full.es5.js 251 kB -557 B (-0.22%)
dist/array.full.js 341 kB -521 B (-0.15%)
dist/array.full.no-external.js 340 kB -521 B (-0.15%)
dist/array.js 168 kB -520 B (-0.31%)
dist/array.no-external.js 167 kB -520 B (-0.31%)
dist/main.js 169 kB -520 B (-0.31%)
dist/module.full.js 341 kB -521 B (-0.15%)
dist/module.full.no-external.js 340 kB -521 B (-0.15%)
dist/module.js 168 kB -520 B (-0.31%)
dist/module.no-external.js 167 kB -520 B (-0.31%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 193 kB
dist/dead-clicks-autocapture.js 12.8 kB
dist/exception-autocapture.js 8.8 kB
dist/external-scripts-loader.js 2.19 kB
dist/recorder-v2.js 102 kB
dist/recorder.js 103 kB
dist/surveys-preview.js 56.7 kB
dist/surveys.js 62.1 kB
dist/tracing-headers.js 1.33 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@daibhin daibhin requested a review from a team November 14, 2024 13:24
@daibhin daibhin removed the stale label Nov 14, 2024
@daibhin daibhin requested a review from pauldambra November 18, 2024 12:02
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daibhin daibhin merged commit 75296e8 into main Nov 18, 2024
18 checks passed
@daibhin daibhin deleted the dn-chore/remove-custom-endpoint branch November 18, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants