Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow mutation rate limiter configuration #1506

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Oct 31, 2024

see https://posthoghelp.zendesk.com/agent/tickets/20033

We've rewritten ingestion completely since adding SVG throttling and a customer isn't having a great playback experience because of it.

Let's introduce some configurability... it should be that setting

 {
 	session_recording: {
		__mutationRateLimiterRefillRate: 20 // for moderate decrease in throttling
       // or e.g. __mutationRateLimiterRefillRate: 75 // for significant decrease in throttling

this used to have a significant impact on ingestion, but if the customer in the linked ticket is willing to test then we monitor what changes are safe here and maybe even change the defaults

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 31, 2024 10:53am

@pauldambra pauldambra added the bump minor Bump minor version when this PR gets merged label Oct 31, 2024
@pauldambra pauldambra requested a review from a team October 31, 2024 10:53
Copy link

Size Change: +2.52 kB (+0.09%)

Total Size: 2.95 MB

Filename Size Change
dist/array.full.es5.js 249 kB +256 B (+0.1%)
dist/array.full.js 336 kB +252 B (+0.08%)
dist/array.full.no-external.js 335 kB +252 B (+0.08%)
dist/array.js 167 kB +252 B (+0.15%)
dist/array.no-external.js 166 kB +252 B (+0.15%)
dist/main.js 167 kB +252 B (+0.15%)
dist/module.full.js 336 kB +252 B (+0.08%)
dist/module.full.no-external.js 335 kB +252 B (+0.08%)
dist/module.js 167 kB +252 B (+0.15%)
dist/module.no-external.js 166 kB +252 B (+0.15%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 182 kB
dist/exception-autocapture.js 8.77 kB
dist/external-scripts-loader.js 2.19 kB
dist/recorder-v2.js 102 kB
dist/recorder.js 103 kB
dist/surveys-preview.js 56.7 kB
dist/surveys.js 62.1 kB
dist/tracing-headers.js 1.33 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@pauldambra pauldambra merged commit 58d2e00 into main Oct 31, 2024
18 checks passed
@pauldambra pauldambra deleted the feat/configurable-svg-throttling branch October 31, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants