Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set platform on stack frame #1495

Merged
merged 3 commits into from
Oct 24, 2024
Merged

chore: set platform on stack frame #1495

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c93179
chore: add lang to stack frames
daibhin Oct 23, 2024
9de1d0f
Merge branch 'main' into dn-chore/add-frame-lang
daibhin Oct 24, 2024
11304e0
use platform over lang
daibhin Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/extensions/exception-autocapture/stack-trace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ export type StackLineParserFn = (line: string) => StackFrame | undefined
export type StackLineParser = [number, StackLineParserFn]

export interface StackFrame {
platform: string
filename?: string
function?: string
module?: string
platform?: string
lineno?: number
colno?: number
abs_path?: string
Expand All @@ -63,6 +63,7 @@ const GECKO_PRIORITY = 50

function createFrame(filename: string, func: string, lineno?: number, colno?: number): StackFrame {
const frame: StackFrame = {
platform: 'javascript',
filename,
function: func === '<anonymous>' ? UNKNOWN_FUNCTION : func,
in_app: true, // All browser frames are considered in_app
Expand Down
Loading