feat: Only set missing campaign params to null if there is at least one non-null #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +748 B (+0.03%) Total Size: 2.89 MB
ℹ️ View Unchanged
|
robbie-c
changed the title
robbie-c
changed the title
pauldambra
approved these changes
Oct 28, 2024
| // only save campaign params if there were any | ||
| if (!isEmptyObject(stripEmptyProperties(campaignParams))) { | ||
| this.register(Info.campaignParams(this.config.custom_campaign_params)) | ||
| } | ||
| this.campaign_params_saved = true |
There was a problem hiding this comment.
should we only be marked them as saved when we did send something or doesn't matter?
There was a problem hiding this comment.
This flag is there to make sure we get the campaign params from the start of the session only, so I think it's correct as is. We want to set the flag regardless of whether we save anything, so that we don't pick up campaign params from later in the session.
robbie-c
deleted the
feature/only-set-properties-to-null-when-any-are-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See this ticket https://posthoghelp.zendesk.com/agent/tickets/19698
We definitely want to keep something similar to the changed logic. i.e. if one session has utm_source = source, and the next session has utm_medium = medium.
However, we could prevent overwriting the campaign params if there are none set.
Had a discussion with @neilkakkar about it here https://posthog.slack.com/archives/C05LJK1N3CP/p1729764244044729
Checklist