Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty query param when calling external dependency toolbar.js #1456

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: empty query param when calling external dependency toolbar.js #1456

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1235c2
Fix empty query param when calling external dependency toolbar.js
lucasra1 Oct 7, 2024
52b7c80
update test
pauldambra Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/entrypoints/external-scripts-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ assignableWindow.__PosthogExtensions__.loadExternalDependency = (
// this ensures that we bust the cache periodically
const timestampToNearestFiveMinutes = Math.floor(Date.now() / fiveMinutesInMillis) * fiveMinutesInMillis

scriptUrlToLoad = `${scriptUrlToLoad}?&=${timestampToNearestFiveMinutes}`
scriptUrlToLoad = `${scriptUrlToLoad}&t=${timestampToNearestFiveMinutes}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we totally missed this PR sorry...

}
const url = posthog.requestRouter.endpointFor('assets', scriptUrlToLoad)

Expand Down
Loading