Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circular refs shouldn't explode capture #1230

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

pauldambra
Copy link
Member

This stops estimation of size of an rrweb event containing an object with a circular reference from exploding

It doesn't edit the actual emitted data in case that's necessary for playback

see https://posthog.com/questions/uncaught-error

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jun 7, 2024 9:49pm

Copy link

github-actions bot commented Jun 7, 2024

Size Change: +673 B (+0.07%)

Total Size: 998 kB

Filename Size Change
dist/array.full.js 237 kB +169 B (+0.07%)
dist/array.js 134 kB +168 B (+0.13%)
dist/es.js 134 kB +168 B (+0.13%)
dist/module.js 135 kB +168 B (+0.12%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.2 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 59.3 kB
dist/surveys.js 60.9 kB
dist/tracing-headers.js 8.26 kB

compressed-size-action

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Jun 7, 2024
@pauldambra pauldambra requested a review from a team June 7, 2024 21:52
@rahulkgupta
Copy link

fixes #1229

@pauldambra pauldambra merged commit 494c08e into main Jun 10, 2024
12 checks passed
@pauldambra pauldambra deleted the fix/circular-refs-explode-recording-capture branch June 10, 2024 11:10
@rahulkgupta
Copy link

Thanks for the change. I unfortunately dont think it fixed the issue. Here's a PR with more info: 3DStreet/3dstreet#601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants