Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decide): Respect disable_compression for flags #1102

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

neilkakkar
Copy link
Collaborator

@neilkakkar neilkakkar commented Mar 29, 2024

Changes

Don't compress decide requests when disable_compression is set.

Seems we missed this in the request refactor, as previously when this config option was set, decide would disable compression as well. Had a user request about this.
...

added unit tests, ran locally with posthog and see everything works as expected

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@neilkakkar neilkakkar marked this pull request as ready for review March 29, 2024 12:16
Copy link

Size Change: +272 B (0%)

Total Size: 943 kB

Filename Size Change
dist/array.full.js 225 kB +68 B (0%)
dist/array.js 124 kB +68 B (0%)
dist/es.js 124 kB +68 B (0%)
dist/module.js 125 kB +68 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.1 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 106 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@neilkakkar neilkakkar added the bump patch Bump patch version when this PR gets merged label Mar 29, 2024
@neilkakkar neilkakkar merged commit 3921f5b into main Apr 3, 2024
15 checks passed
@neilkakkar neilkakkar deleted the compression-decide branch April 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants