Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow payload scrubbing override #1085

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Mar 15, 2024

We don't allow someone to override our header scrubbing. That's fine because we're concrete about what we detect and remove.

We also don't allow someone to override our payload scubbing, but that's purposefully leaning towards false positives over false negatives. So, we can redact content that isn't actually private. Great for safety but not usability.

This changes so that the network mask function replaces the scrubPayload function (as requested by a customer)


I considered double opt-in e.g. requiring config.maskFnOverridesDefaultScrubbing = true but that felt too much on top of a dialog in the app and having to provide a masking function

@pauldambra pauldambra requested review from benjackwhite and a team March 15, 2024 11:11
Copy link

github-actions bot commented Mar 15, 2024

Size Change: -76 B (0%)

Total Size: 941 kB

Filename Size Change
dist/array.full.js 224 kB -19 B (0%)
dist/array.js 124 kB -19 B (0%)
dist/es.js 124 kB -19 B (0%)
dist/module.js 124 kB -19 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.1 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 106 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@pauldambra pauldambra added the bump minor Bump minor version when this PR gets merged label Mar 15, 2024
@pauldambra pauldambra merged commit 7ceed28 into main Mar 15, 2024
14 checks passed
@pauldambra pauldambra deleted the fix/allow-payload-scrubbing-overridde branch March 15, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants