fix: allow payload scrubbing override #1085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't allow someone to override our header scrubbing. That's fine because we're concrete about what we detect and remove.
We also don't allow someone to override our payload scubbing, but that's purposefully leaning towards false positives over false negatives. So, we can redact content that isn't actually private. Great for safety but not usability.
This changes so that the network mask function replaces the
scrubPayload
function (as requested by a customer)I considered double opt-in e.g. requiring
config.maskFnOverridesDefaultScrubbing = true
but that felt too much on top of a dialog in the app and having to provide a masking function