fix: specify transport in fewer places to let config control (#1614)

* fix: specify transport in fewer places to let config control * fix
PostHog · Dec 17, 2024 · f87ef93 · f87ef93
1 parent ddd8903
commit f87ef93
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 7 deletions.
diff --git a/src/__tests__/featureflags.test.ts b/src/__tests__/featureflags.test.ts
@@ -475,7 +475,6 @@ describe('featureflags', () => {
             expect(instance._send_request).toHaveBeenCalledWith({
                 url: 'https://us.i.posthog.com/api/early_access_features/?token=random fake token',
                 method: 'GET',
-                transport: 'fetch',
                 callback: expect.any(Function),
             })
             expect(instance._send_request).toHaveBeenCalledTimes(1)
@@ -507,7 +506,6 @@ describe('featureflags', () => {
                 url: 'https://us.i.posthog.com/api/early_access_features/?token=random fake token',
                 method: 'GET',
                 callback: expect.any(Function),
-                transport: 'fetch',
             })
             expect(instance._send_request).toHaveBeenCalledTimes(1)
 

diff --git a/src/__tests__/surveys.test.ts b/src/__tests__/surveys.test.ts
@@ -236,7 +236,6 @@ describe('surveys', () => {
         expect(instance._send_request).toHaveBeenCalledWith({
             url: 'https://us.i.posthog.com/api/surveys/?token=testtoken',
             method: 'GET',
-            transport: 'fetch',
             callback: expect.any(Function),
         })
         expect(instance._send_request).toHaveBeenCalledTimes(1)
@@ -281,7 +280,6 @@ describe('surveys', () => {
         expect(instance._send_request).toHaveBeenCalledWith({
             url: 'https://us.i.posthog.com/api/surveys/?token=testtoken',
             method: 'GET',
-            transport: 'fetch',
             callback: expect.any(Function),
         })
         expect(instance._send_request).toHaveBeenCalledTimes(1)

diff --git a/src/posthog-featureflags.ts b/src/posthog-featureflags.ts
@@ -433,7 +433,6 @@ export class PostHogFeatureFlags {
 
         if (!existing_early_access_features || force_reload) {
             this.instance._send_request({
-                transport: 'fetch',
                 url: this.instance.requestRouter.endpointFor(
                     'api',
                     `/api/early_access_features/?token=${this.instance.config.token}`

diff --git a/src/posthog-surveys.ts b/src/posthog-surveys.ts
@@ -118,7 +118,6 @@ export class PostHogSurveys {
                     `/api/surveys/?token=${this.instance.config.token}`
                 ),
                 method: 'GET',
-                transport: 'fetch',
                 callback: (response) => {
                     if (response.statusCode !== 200 || !response.json) {
                         return callback([])

diff --git a/src/web-experiments.ts b/src/web-experiments.ts
@@ -151,7 +151,6 @@ export class WebExperiments {
                 `/api/web_experiments/?token=${this.instance.config.token}`
             ),
             method: 'GET',
-            transport: 'fetch',
             callback: (response) => {
                 if (response.statusCode !== 200 || !response.json) {
                     return callback([])