fix: block bytespider bot (#1113)

PostHog · Apr 3, 2024 · 5a3e62d · 5a3e62d
1 parent 7c7dfde
commit 5a3e62d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/__tests__/utils.test.ts b/src/__tests__/utils.test.ts
@@ -161,6 +161,9 @@ describe('utils', () => {
             ],
             ['AhrefsSiteAudit (Desktop) - Mozilla/5.0 (compatible; AhrefsSiteAudit/6.1; +http://ahrefs.com/robot/)'],
             ['Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; GPTBot/1.0; +https://openai.com/gptbot)'],
+            [
+                'Mozilla/5.0 (Linux; Android 5.0) AppleWebKit/537.36 (KHTML, like Gecko) Mobile Safari/537.36 (compatible; Bytespider; [email protected])',
+            ],
         ])('blocks based on user agent', (botString) => {
             expect(_isBlockedUA(botString, [])).toBe(true)
             expect(_isBlockedUA(botString.toLowerCase(), [])).toBe(true)

diff --git a/src/utils/blocked-uas.ts b/src/utils/blocked-uas.ts
@@ -46,6 +46,7 @@ export const DEFAULT_BLOCKED_UA_STRS = [
     'googleweblight',
     'mediapartners-google',
     'storebot-google',
+    'Bytespider;',
 ]
 
 /**
@@ -58,11 +59,8 @@ export const _isBlockedUA = function (ua: string, customBlockedUserAgents: strin
     const uaLower = ua.toLowerCase()
     return DEFAULT_BLOCKED_UA_STRS.concat(customBlockedUserAgents || []).some((blockedUA) => {
         const blockedUaLower = blockedUA.toLowerCase()
-        if (uaLower.includes) {
-            return uaLower.includes(blockedUaLower)
-        } else {
-            // IE 11 :/
-            return uaLower.indexOf(blockedUaLower) !== -1
-        }
+
+        // can't use includes because IE 11 :/
+        return uaLower.indexOf(blockedUaLower) !== -1
     })
 }