Removed as, fixed types in isElementInToolbar

PostHog · Dec 19, 2024 · 586f1fd · 586f1fd
1 parent 7d11d7f
commit 586f1fd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/heatmaps.ts b/src/heatmaps.ts
@@ -177,7 +177,7 @@ export class Heatmaps {
     }
 
     private _onMouseMove(e: Event): void {
-        if (isElementInToolbar(e.target as Element)) {
+        if (isElementInToolbar(e.target)) {
             return
         }
         clearTimeout(this._mouseMoveTimeout)

diff --git a/src/utils/element-utils.ts b/src/utils/element-utils.ts
@@ -1,8 +1,11 @@
 import { TOOLBAR_CONTAINER_CLASS, TOOLBAR_ID } from '../constants'
 
-export function isElementInToolbar(el: Element | null): boolean {
-    // NOTE: .closest is not supported in IE11 hence the operator check
-    return el?.id === TOOLBAR_ID || !!el?.closest?.('.' + TOOLBAR_CONTAINER_CLASS)
+export function isElementInToolbar(el: EventTarget | null): boolean {
+    if (el instanceof Element) {
+        // NOTE: .closest is not supported in IE11 hence the operator check
+        return el.id === TOOLBAR_ID || !!el.closest?.('.' + TOOLBAR_CONTAINER_CLASS)
+    }
+    return false
 }
 
 /*