fix: empty query param when calling external dependency toolbar.js (#…

…1456) Co-authored-by: Paul D'Ambra <[email protected]>
PostHog · Oct 28, 2024 · 5413bed · 5413bed
1 parent 3cbd118
commit 5413bed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/__tests__/utils/external-scripts-loader.test.ts b/src/__tests__/utils/external-scripts-loader.test.ts
@@ -59,9 +59,7 @@ describe('external-scripts-loader', () => {
             assignableWindow.__PosthogExtensions__.loadExternalDependency(mockPostHog, 'toolbar', callback)
             const scripts = document!.getElementsByTagName('script')
             const new_script = scripts[0]
-            expect(new_script.src).toMatchInlineSnapshot(
-                `"https://us-assets.i.posthog.com/static/toolbar.js?v=1.0.0?&=1726067100000"`
-            )
+            expect(new_script.src).toBe('https://us-assets.i.posthog.com/static/toolbar.js?v=1.0.0&t=1726067100000')
         })
     })
 })
diff --git a/src/entrypoints/external-scripts-loader.ts b/src/entrypoints/external-scripts-loader.ts
@@ -50,7 +50,7 @@ assignableWindow.__PosthogExtensions__.loadExternalDependency = (
         // this ensures that we bust the cache periodically
         const timestampToNearestFiveMinutes = Math.floor(Date.now() / fiveMinutesInMillis) * fiveMinutesInMillis
 
-        scriptUrlToLoad = `${scriptUrlToLoad}?&=${timestampToNearestFiveMinutes}`
+        scriptUrlToLoad = `${scriptUrlToLoad}&t=${timestampToNearestFiveMinutes}`
     }
     const url = posthog.requestRouter.endpointFor('assets', scriptUrlToLoad)