Fix string formatting a float without explicit locale #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use explicit Locale.US in String.format, * yrel is read back using toFloatOrNull(), which requires a decimal point.
I think yes, afaik it was supposed to tell position of images on the page, but we don't really use that method to parse images, so it should be safe to just remove it. |
starry-shivam
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the internal reader shows me all images as their html tags i.e.
<img src=... yrel=...>. This is because of a localization bug when formatting and then later parsingyrel. I fixed this by explicitly usingLocale.US, however I see thatyrelisn't even used in the internal reader. Is it maybe better to simply remove it?