Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polymer 3 #36

Open
wants to merge 1 commit into
base: 3.0-preview
Choose a base branch
from

Conversation

jorgecasar
Copy link

Changes:

marked-element

  • is contained within @Polymer so we need to move up an extra folder to get to @webcomponents (Also, add @webcomponents to the webcomponentsjs path.) (Polymer/polymer-modulizer#174)
  • Removed the extra file from the previous work around in HTML Imports for loading a JS file. Swapped to using the import inline. (Polymer/polymer-modulizer#182)
  • Removed 'use strict'; since this is always enabled in modules now. (Polymer/polymer-modulizer#181)
  • Added the missing marked dependency from conversion. (Polymer/polymer-modulizer#174)
  • Added the paper-styles dev depenency for demo. (Polymer/polymer-modulizer#176)
  • Added node_modules to .gitignore (Polymer/polymer-modulizer#183)
  • Added *.lock to .gitignore (Polymer/polymer-modulizer#183)
  • Update Tests to use "legacy" wct-legacy-browser and all references (Thanks @usergenic)
  • Tests aren't working with polymer test --npm (@usergenic any thoughts? Polymer/polymer-cli#858)
  • Update .travis.yml to run polymer test --npm and install using yarn

Other things to note:

  • iron-component-page isn't working (No 3.0-preview branch, Polymer/polymer-modulizer#180)

@rictic @e111077 PTAL

@jorgecasar jorgecasar changed the base branch from master to 3.0-preview August 25, 2017 12:06
@stramel
Copy link

stramel commented Aug 25, 2017

@jorgecasar I believe the consensus is to make these changes upstream instead of manually since they plan to apply these changes in bulk with a new run of polymer-modulizer once these issues are addressed.

Adding a couple of issue references missed here:

Update .travis.yml to run polymer test --npm and install using yarn

Related Issue: https://github.com/Polymer/polymer-modulizer/issues/186

Update Tests to use "legacy" wct-legacy-browser and all references

Related Issue: https://github.com/Polymer/polymer-modulizer/issues/93

@jorgecasar
Copy link
Author

Nice, it will be a better solution for sure. I will wait then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants