Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clob package version #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jfullerton44
Copy link

@jfullerton44 jfullerton44 commented Jul 5, 2024

Overview

Updates the clob package version to fix runtime issue

Description

Updates the clob package version to fix and error when iterating through order responses. The new clob version also fixes an issue where there is a type mismatch when looking up values in a dictionary.

Types of changes

  • Refactor/enhancement
  • Bug fix/behavior correction
  • New feature
  • Breaking change
  • Other, additional

Status

  • Prefix PR title with [WIP] if necessary (changes not yet made).
  • Add tests to cover changes as needed.
  • Update documentation/changelog as needed.
  • Verify all tests run correctly in CI and pass.
  • Ready for review/merge.

Copy link

@Ragnoraks Ragnoraks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work!

@AceBeaker2
Copy link

AceBeaker2 commented Oct 24, 2024

Looks like FilterParams was split into OpenOrderParams and TradeParams. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants