-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Allowances #24
Merged
Merged
Fix Allowances #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanAmenechi
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
L-Kov
reviewed
Nov 7, 2023
L-Kov
reviewed
Nov 7, 2023
L-Kov
reviewed
Nov 7, 2023
L-Kov
reviewed
Nov 7, 2023
L-Kov
reviewed
Nov 22, 2023
L-Kov
reviewed
Nov 22, 2023
L-Kov
approved these changes
Nov 23, 2023
JonathanAmenechi
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues integrating the (NegRisk)CtfExchange with the NegRiskAdapter.
In
matchOrders
, it is necessary to callsafeTransferFrom
, as well to query the balances of an address.The NegRiskCtfExchange treats the NegRiskAdapter as the CTF, so it is necessary to proxy
balanceOf
andsafeTransferFrom
to the CTF.The primary addition is the following:
There are two safety measures to prevent unauthorized transfers.
safeTransferFrom
is marked asonlyAdmin
. This means that no caller may call this function unless they are added as an admin on the NegRiskAdapter. There are only two addresses that should call this function: the NegRiskCtfExchange during the execution ofmatchOrders
and the NegRiskFeeModule during the execution ofwithdrawFees
.safeTransferFrom
checks that the_from
address has approvedmsg.sender
to transfer their conditional tokens. This means that the_from
address must approve the NegRiskCtfAdapter. This also means that the_from
address can prevent the NegRiskCtfAdapter from transferring their conditional tokens by revoking allowances.Additionally, the CTF itself enforces that the
_from
address must approve the NegRiskAdapter to spend their conditional tokens. If the_from
address has not approved the NegRiskAdapter, the call will revert at the CTF.This PR also changes the NegRiskOperator's
DELAY_PERIOD
to 1 hour.