-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neg Risk Support #100
Neg Risk Support #100
Conversation
|
||
return this.orderBuilder.buildOrder(userOrder, tickSize); | ||
const tickSize = await this._resolveTickSize(tokenID, options?.tickSize); | ||
const negRisk = options?.negRisk ?? false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the frontend will known at the time of calling whether the market is neg-risk or not. We considered adding an extra call to the CLOB to determine locally (to this package) whether the market is neg-risk but opted to make these calls as light-weight as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it makes sense, thanks!
Modifies the Clob Client in anticipation of the future Neg Risk market type.
Adds a new
OrderOptions
object:These modifications do not require extra calls to the CLOB, e.g., to get the exchange address to be used when signing.
Contract addresses are now hard-coded in this repo, as opposed to retrieved from the
clob-order-utils
.