Update autostory segments and DialogArrowDetector #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysticial
reviewed
Dec 1, 2024
| @@ -895,7 +895,6 @@ void mash_button_till_overworld( | |||
| uint16_t button, uint16_t seconds_run | |||
| ){ | |||
| OverworldWatcher overworld(console, COLOR_CYAN); | |||
| NormalBattleMenuWatcher battle(COLOR_BLUE); | |||
There was a problem hiding this comment.
mash_button_till_overworld is usually used in similar situations as clear_dialog. It can also mash through battles itself. So, it's usually used in situations where unexpected battles aren't possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of minor changes to autostory segments.
Updated DialogArrowDetector to reduce false negatives, in case the detector temporarily loses track of the arrow for a few frames.