Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Bundle Fixes #507

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Mac Bundle Fixes #507

merged 3 commits into from
Nov 14, 2024

Conversation

Ericzklm
Copy link
Contributor

Various fixes relating to the MacOS SerialPrograms app bundle

  • Modifying external filepaths to use the .app base directory instead of the executable's Contents/MacOS/ directory
    • Needed in order to enable SerialPrograms.log and other dumps. This stops the program from attempting to write in write-protected space inside the bundle
    • Needed to avoid collision between the SerialProgram's "Resources" folder and the "Resources" folder automatically defined in the .app bundle
  • Modified the location of the SerialPrograms.log to use an absolute filepath located outside the .app bundle for MacOS
  • Created an Apple Icon Image file and linked it to the .app bundle during build

Set base directory outside MacOS app bundle
Explicitly defining SerialPrograms.log on MacOS
@Mysticial Mysticial requested a review from Gin890 November 14, 2024 09:59
@Gin890
Copy link
Collaborator

Gin890 commented Nov 14, 2024

Thank you for the PR. I tried to add an icon image to the program but for some reason I could not get it working. The compiled program did not show the icon correctly. Hope this PR solves that!

@Gin890 Gin890 merged commit 7f43c43 into PokemonAutomation:main Nov 14, 2024
6 checks passed
@Ericzklm
Copy link
Contributor Author

Sorry didn't get a chance to follow-up before the merge.

The IconResource folder looked to contain only icon related files so I thought to stick the icon.icns in there as well. It can be moved into the SerialPrograms Resources if that's a better location for it.

The Icon should work! I was confused for a bit because the Icon wasn't showing up when it should have but the problem was just that Finder had cached the blank icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants